Skip to content

[PTDT-0] Update tests to contain classifications field for TextAnswer #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kjamrozy
Copy link
Contributor

@kjamrozy kjamrozy commented Nov 16, 2024

Description

Since new version of the exporter returns classifications field for the text classifications(in order to support subclassifications for text classification), tests needed to be updated accordingly.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@kjamrozy kjamrozy requested a review from a team as a code owner November 16, 2024 00:34
@kjamrozy kjamrozy force-pushed the kjamrozy/text-answer-classification-field-unit-test-updates branch from de152e0 to 2835cb2 Compare November 20, 2024 19:47
@kjamrozy kjamrozy requested a review from a team as a code owner November 20, 2024 19:47
@kjamrozy kjamrozy force-pushed the kjamrozy/text-answer-classification-field-unit-test-updates branch from 2835cb2 to baf6139 Compare November 20, 2024 19:47
@kjamrozy kjamrozy force-pushed the kjamrozy/text-answer-classification-field-unit-test-updates branch from baf6139 to b4bba0c Compare November 20, 2024 20:05
@kjamrozy kjamrozy force-pushed the kjamrozy/text-answer-classification-field-unit-test-updates branch from b4bba0c to 7af75e4 Compare November 20, 2024 20:06
@kjamrozy kjamrozy force-pushed the kjamrozy/text-answer-classification-field-unit-test-updates branch from 7af75e4 to f70a159 Compare November 20, 2024 20:11
@kjamrozy kjamrozy force-pushed the kjamrozy/text-answer-classification-field-unit-test-updates branch from f70a159 to 667224f Compare November 20, 2024 20:14
@vbrodsky vbrodsky merged commit b798c01 into develop Nov 20, 2024
16 of 23 checks passed
@vbrodsky vbrodsky deleted the kjamrozy/text-answer-classification-field-unit-test-updates branch November 20, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants